-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to merge #4271 (for #1467) to master
(2 failures wrt Creator name mismatch)
#4797
Try to merge #4271 (for #1467) to master
(2 failures wrt Creator name mismatch)
#4797
Conversation
Hmmmh. So close yet so far. Was able to figure out issue with But this leaves 2 remaining test failures that seem legit. EDIT: exception message seems to suggest mismatch between incoming names, creator parameters (which is why "fallback setter" is being checked), so I am suspecting some missing renaming (or missing re-creation of matchers). cc @JooHyukKim |
Seems like a big work we got here :-) |
@JooHyukKim thanks! I'm sure all of us together can figure it out. In the worst case could just move 2 failing tests under "tofix". |
master
; problem with lack of access to DeserializationContextmaster
(2 failures wrt Creator name mismatch)
Decided to move 2 failing tests under |
So: hoping to get #4271 merged, but this gets tricky for one specific aspect.
Hoping to get it resolved, otherwise cannot get feature in 3.0.